Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Delete a hop with one click #3130

Closed
gertwieland opened this issue Aug 1, 2023 · 4 comments · Fixed by #3134
Closed

[Feature Request]: Delete a hop with one click #3130

gertwieland opened this issue Aug 1, 2023 · 4 comments · Fixed by #3134
Assignees
@nadment
Labels
Hop Gui new feature P3 Nice to have
Milestone
2.6

Comments

@gertwieland
Copy link

gertwieland commented Aug 1, 2023 •
edited
Loading

What would you like to happen?

Ctrl-click (or middle-click) deactivates a hop.

Could we have "Shift-click (or right-click) to delete a hop?
Purpose: Reduce the overall number of clicks required during development.

Regular left-click would still open the context menu.

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui
@github-actions github-actions bot added P3 Nice to have Hop Gui labels Aug 1, 2023
@nadment
Copy link
Contributor

nadment commented Aug 1, 2023 •
edited
Loading

Good idea, I suggest using the following combination "CONTROL + SHIFT + left click" to delete a hop to limit unintentional deletions.

@gertwieland
Copy link
Author

Glad you like it, @nadment. I have no particular preference, and CONTROL + SHIFT is a very simple combination.

@nadment nadment self-assigned this Aug 2, 2023
@nadment
Copy link
Contributor

nadment commented Aug 2, 2023

I'm testing it out and it seems to be useful with Ctrl+Shift+left click

nadment added a commit to nadment/hop that referenced this issue Aug 2, 2023
@nadment
Delete a hop with one click apache#3130
f0f447d
@nadment nadment linked a pull request Aug 2, 2023 that will close this issue
Delete a hop with one click #3130 #3134
Merged
hansva added a commit that referenced this issue Aug 3, 2023
@hansva
Merge pull request #3134 from nadment/3130
e1b6e34 
Delete a hop with one click #3130
@hansva hansva added this to the 2.6 milestone Aug 3, 2023
@gertwieland
Copy link
Author

Thank you, @nadment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadment nadment

Labels
Hop Gui new feature P3 Nice to have
Projects
None yet
Milestone
2.6
Development

Successfully merging a pull request may close this issue.

Delete a hop with one click #3130 nadment/hop
3 participants
@hansva @nadment @gertwieland