Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Workflow executor: do not fire consistency check in case there are no result from sub-workflows #2883

Closed
sramazzina opened this issue Apr 28, 2023 · 0 comments · Fixed by #2897
Closed

[Feature Request]: Workflow executor: do not fire consistency check in case there are no result from sub-workflows #2883

sramazzina opened this issue Apr 28, 2023 · 0 comments · Fixed by #2897
Assignees
@sramazzina
Labels
new feature P3 Nice to have Transforms
Milestone
2.5

Comments

@sramazzina
Copy link
Contributor

What would you like to happen?

In WorkflowExecutor, whenever the sub-workflow calls one or more pipelines and the last pipeline in this workflow is not going to provide any result rows, the consistency check must not fire because not necessary.

Issue Priority

Priority: 3

Issue Component

Component: Transforms
@sramazzina sramazzina added this to the 2.5 milestone Apr 28, 2023
@sramazzina sramazzina self-assigned this Apr 28, 2023
@github-actions github-actions bot added P3 Nice to have Transforms labels Apr 28, 2023
sramazzina added a commit to sramazzina/hop that referenced this issue May 3, 2023
@sramazzina
fix apache#2883 Workflow executor: do not fire consistency check in c…
e96227f 
…ase there are no result from sub-workflows
@sramazzina sramazzina mentioned this issue May 3, 2023
Merged
5 tasks
hansva added a commit that referenced this issue May 17, 2023
@hansva
Merge pull request #2897 from sramazzina/2883
8c29029 
fix #2883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sramazzina sramazzina

Labels
new feature P3 Nice to have Transforms
Projects
None yet
Milestone
2.5
Development

Successfully merging a pull request may close this issue.

fix #2883 sramazzina/hop
2 participants
@hansva @sramazzina