HIVE-28661: OTEL: Latency in retrieving query end time leads to threa… #5576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushtkn
reviewed
Dec 10, 2024
service/src/java/org/apache/hive/service/servlet/OTELExporter.java
Outdated
Show resolved
Hide resolved
tanishq-chugh
force-pushed
the
HIVE-28661
branch
from
ac2c7a2 to
b3c7fd5
Compare
asf-ci-hive
added
tests pending
tests failed
tests unstable
and removed
tests passed
tests pending
tests failed
tests unstable
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d interruption
What changes were proposed in this pull request?
Changes to address OTEL thread running into NullPointerException
Why are the changes needed?
Needed to ensure the OTEL thread does not get interrupted in case of NullPointerException arising because query end time is not available at the time it is fetched. Additionally, a try-catch block is introduced to avoid OTEL thread interruption.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Manual testing, by running the OTEL service with Jaeger and Zipkin recievers.