Add an end to end test for helix gateway #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyuanlu
force-pushed
the
gateway-e2etest
branch
3 times, most recently
from
6a9cb1d to
73a9ef1
Compare
asfgit
force-pushed
the
helix-gateway-service
branch
from
1c17076 to
e15c9d2
Compare
xyuanlu
force-pushed
the
gateway-e2etest
branch
from
73a9ef1 to
bfbd2a0
Compare
zpinto
reviewed
Sep 19, 2024
| @@ -165,7 +165,7 @@ public static GatewayServiceEvent translateCurrentStateChangeToEvent(String inst | |||
| * @param shardStateMap the initial state of shards on the participant. Could be empty map | |||
| * @return | |||
| */ | |||
| public static GatewayServiceEvent translateCurrentStateDiffToInitConnectEvent(String instanceName, String clusterName, | |||
| public static GatewayServiceEvent translateCurrentStateDiffToInitConnectEvent( String clusterName, String instanceName, | |||
There was a problem hiding this comment.
Fix whitespace before "String"
zpinto
reviewed
Sep 19, 2024
| @@ -144,7 +144,7 @@ public static GatewayServiceEvent translateClientCloseToEvent(String instanceNam | |||
| * @param shardStateMap | |||
| * @return | |||
| */ | |||
| public static GatewayServiceEvent translateCurrentStateChangeToEvent(String instanceName, String clusterName, | |||
| public static GatewayServiceEvent translateCurrentStateChangeToEvent( String clusterName, String instanceName, | |||
| @@ -130,7 +130,7 @@ public static GatewayServiceEvent translateShardStateMessageToEventAndUpdateCach | |||
| * @param clusterName the cluster name | |||
| * @return GatewayServiceEvent | |||
| */ | |||
| public static GatewayServiceEvent translateClientCloseToEvent(String instanceName, String clusterName) { | |||
| public static GatewayServiceEvent translateClientCloseToEvent( String clusterName, String instanceName) { | |||
junkaixue
approved these changes
Sep 23, 2024
|
This change is ready to be merged. Approved by @junkaixue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#2821
Description
This change add e2e test and fix some bugs
Tests
TestFilePullChannelE2E
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)