Gateway - Add GatewayCurrentStateCache for gateway service #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkaixue
reviewed
Aug 29, 2024
helix-gateway/src/main/java/org/apache/helix/gateway/util/GatewayCurrentStateCache.java
Outdated
Show resolved
Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/util/GatewayCurrentStateCache.java
Outdated
Show resolved
Hide resolved
junkaixue
reviewed
Aug 29, 2024
helix-gateway/src/main/java/org/apache/helix/gateway/util/GatewayCurrentStateCache.java
Outdated
Show resolved
Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/util/GatewayCurrentStateCache.java
Outdated
Show resolved
Hide resolved
xyuanlu
force-pushed
the
gatewayservice-4
branch
from
f8f9c6a to
7acfcbb
Compare
xyuanlu
force-pushed
the
gatewayservice-4
branch
from
7acfcbb to
45312d1
Compare
junkaixue
reviewed
Aug 30, 2024
Comment on lines
134
to
138
| currentMap.get(instance).entrySet().stream().forEach(e -> { | ||
| if (currentState.get(e.getKey()) != null) { | ||
| e.setValue(currentState.get(e.getKey())); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Why update the entry of the diff map? That's tmp object.
There was a problem hiding this comment.
We are updating the currentMap, with diff map value.
xyuanlu
force-pushed
the
gatewayservice-4
branch
4 times, most recently
from
bd7865d to
bc8698f
Compare
junkaixue
reviewed
Sep 3, 2024
helix-gateway/src/main/java/org/apache/helix/gateway/service/GatewayServiceManager.java
Outdated
Show resolved
Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/util/GatewayCurrentStateCache.java
Outdated
Show resolved
Hide resolved
Comment on lines
77
to
94
| public void updateCacheWithCurrentStateDiff(Map<String, Map<String, Map<String, String>>> currentStateDiff) { | ||
| for (String instance : currentStateDiff.keySet()) { | ||
| Map<String, Map<String, String>> currentStateDiffMap = currentStateDiff.get(instance); | ||
| _currentStateMap.computeIfAbsent(instance, k -> new ShardStateMap(new HashMap<>())) | ||
| .updateShardStateMapWithDiff(currentStateDiffMap); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Update the target state with the changed target state maps. | ||
| * All existing target states remains the same | ||
| * @param targetStateChangeMap | ||
| */ | ||
| public void updateTargetStateWithDiff(String instance, Map<String, Map<String, String>> targetStateChangeMap) { | ||
| _targetStateMap.computeIfAbsent(instance, k -> new ShardStateMap(new HashMap<>())) | ||
| .updateShardStateMapWithDiff(targetStateChangeMap); | ||
| } |
There was a problem hiding this comment.
They update different maps
There was a problem hiding this comment.
Or let's combine? Have the second one as a private wrapper function. So the first one can do:
for (xxxxx) {
private func on each instance
}
Because I think the logic of codes are almost same.
xyuanlu
force-pushed
the
gatewayservice-4
branch
from
bc8698f to
39325a2
Compare
junkaixue
reviewed
Sep 3, 2024
Comment on lines
77
to
94
| public void updateCacheWithCurrentStateDiff(Map<String, Map<String, Map<String, String>>> currentStateDiff) { | ||
| for (String instance : currentStateDiff.keySet()) { | ||
| Map<String, Map<String, String>> currentStateDiffMap = currentStateDiff.get(instance); | ||
| _currentStateMap.computeIfAbsent(instance, k -> new ShardStateMap(new HashMap<>())) | ||
| .updateShardStateMapWithDiff(currentStateDiffMap); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Update the target state with the changed target state maps. | ||
| * All existing target states remains the same | ||
| * @param targetStateChangeMap | ||
| */ | ||
| public void updateTargetStateWithDiff(String instance, Map<String, Map<String, String>> targetStateChangeMap) { | ||
| _targetStateMap.computeIfAbsent(instance, k -> new ShardStateMap(new HashMap<>())) | ||
| .updateShardStateMapWithDiff(targetStateChangeMap); | ||
| } |
There was a problem hiding this comment.
Or let's combine? Have the second one as a private wrapper function. So the first one can do:
for (xxxxx) {
private func on each instance
}
Because I think the logic of codes are almost same.
helix-gateway/src/main/java/org/apache/helix/gateway/util/GatewayCurrentStateCache.java
Show resolved
Hide resolved
junkaixue
approved these changes
Sep 4, 2024
|
This change is ready to be merged. Approved by @junkaixue This pull request introduces a caching mechanism for the Helix Gateway service. The main changes include: Addition of a new GatewayCurrentStateCache class in GatewayCurrentStateCache.java, which manages caching of current and target states for instances in a cluster. |
asfgit
pushed a commit
that referenced
this pull request
Sep 6, 2024
This pull request introduces a caching mechanism for the Helix Gateway service. The main changes include: Addition of a new GatewayCurrentStateCache class in GatewayCurrentStateCache.java, which manages caching of current and target states for instances in a cluster.
asfgit
pushed a commit
that referenced
this pull request
Sep 8, 2024
This pull request introduces a caching mechanism for the Helix Gateway service. The main changes include: Addition of a new GatewayCurrentStateCache class in GatewayCurrentStateCache.java, which manages caching of current and target states for instances in a cluster.
asfgit
pushed a commit
that referenced
this pull request
Sep 18, 2024
This pull request introduces a caching mechanism for the Helix Gateway service. The main changes include: Addition of a new GatewayCurrentStateCache class in GatewayCurrentStateCache.java, which manages caching of current and target states for instances in a cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#2821
Description
This pull request introduces a caching mechanism for the Helix Gateway service. The main changes include:
Addition of a new
GatewayCurrentStateCacheclass inGatewayCurrentStateCache.java, which manages caching of current and target states for instances in a cluster.Modification of
GatewayServiceManager.javato incorporate the new caching functionality:_currentStateCacheMapis added to storeGatewayCurrentStateCacheobjects for each cluster.getCurrentStateCache(String clusterName)is introduced to retrieve or create a cache for a given cluster.Test
A new test class
TestGatewayCurrentStateCache.javahas been added with the following tests:Changes that Break Backward Compatibility
N/A
Documentation
N/A
Created with Palmier