address feedback

apache · Dec 19, 2024 · 7eeef92 · 7eeef92
1 parent c60cfb8
commit 7eeef92
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java b/helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java
@@ -864,10 +864,8 @@ private void computeIntermediateMap(PartitionStateMap intermediateStateMap,
       entry.getValue().forEach((key, value) -> {
         if (!value.getToState().equals(HelixDefinedState.DROPPED.name())) {
           intermediateStateMap.setState(entry.getKey(), value.getTgtName(), value.getToState());
-        } else {
-          if (intermediateStateMap.getStateMap().containsKey(entry.getKey())) {
+        } else if (intermediateStateMap.getStateMap().containsKey(entry.getKey())) {
             intermediateStateMap.getStateMap().get(entry.getKey()).remove(value.getTgtName());
-          }
         }
       });
     }