Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squashing Commits of PR#4092 #4100

Closed
wants to merge 1 commit into from

Conversation

Blazer-007
Copy link
Member

@Blazer-007 Blazer-007 commented Feb 21, 2025

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Blazer-007 Blazer-007 changed the title Squashing Commits of DynamicScalingyarnservice changes for handleContainerCompletion Squashing Commits of PR#4092 Feb 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.37%. Comparing base (adef734) to head (cfbfdca).
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4100      +/-   ##
============================================
- Coverage     45.38%   45.37%   -0.01%     
+ Complexity     3192     3191       -1     
============================================
  Files           696      696              
  Lines         26628    26628              
  Branches       2655     2655              
============================================
- Hits          12085    12083       -2     
- Misses        13542    13543       +1     
- Partials       1001     1002       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blazer-007 Blazer-007 closed this Feb 21, 2025
@Blazer-007 Blazer-007 deleted the virai_squashcommits branch February 21, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants