-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOBBLIN-2190] Implement ActivityType & add HeartBeat for Temporal Activities #4093
[GOBBLIN-2190] Implement ActivityType & add HeartBeat for Temporal Activities #4093
Conversation
...al/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityConfigurationStrategy.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityConfigurationStrategy.java
Outdated
Show resolved
Hide resolved
...oral/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/CommitStepWorkflowImpl.java
Outdated
Show resolved
Hide resolved
.../org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java
Show resolved
Hide resolved
.../org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java
Outdated
Show resolved
Hide resolved
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/util/TemporalActivityUtils.java
Outdated
Show resolved
Hide resolved
...obblin/temporal/loadgen/workflow/impl/NestingExecOfIllustrationItemActivityWorkflowImpl.java
Outdated
Show resolved
Hide resolved
.../org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java
Show resolved
Hide resolved
...rc/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ProcessWorkUnitsWorkflowImpl.java
Show resolved
Hide resolved
.../java/org/apache/gobblin/temporal/util/nesting/workflow/AbstractNestingExecWorkflowImpl.java
Show resolved
Hide resolved
As discussed offline, please add the testing details |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4093 +/- ##
============================================
- Coverage 45.38% 43.09% -2.29%
+ Complexity 3192 2467 -725
============================================
Files 696 511 -185
Lines 26628 21499 -5129
Branches 2655 2457 -198
============================================
- Hits 12085 9265 -2820
+ Misses 13542 11289 -2253
+ Partials 1001 945 -56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 19 changed files in this pull request and generated 1 comment.
Files not reviewed (14)
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ProcessWorkUnitsWorkflowImpl.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ProcessWorkUnitsJobLauncher.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/WUProcessingSpec.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/CommitStepWorkflowImpl.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/CommitStepWorkflow.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/util/nesting/workflow/NestingExecWorkflow.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/util/nesting/workflow/AbstractNestingExecWorkflowImpl.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/ProcessWorkUnitsWorkflow.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/loadgen/workflow/impl/NestingExecOfIllustrationItemActivityWorkflowImpl.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/loadgen/launcher/GenArbitraryLoadJobLauncher.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java: Evaluated as low risk
- gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityConfigurationStrategy.java: Evaluated as low risk
Comments suppressed due to low confidence (3)
gobblin-temporal/src/test/java/org/apache/gobblin/temporal/ddm/util/TemporalActivityUtilsTest.java:39
- Mocking ActivityType is unnecessary and might lead to misleading test results. Use a real ActivityType value instead.
ActivityType activityType = Mockito.mock(ActivityType.class);
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/util/TemporalActivityUtils.java:49
- Add validation to ensure that every ActivityType has a corresponding strategy to prevent runtime errors.
private static final Map<ActivityType, ActivityConfigurationStrategy> activityConfigurationStrategies = new HashMap<>();
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/util/TemporalActivityUtils.java:29
- Correct the spelling of 'Temporal' in the comment on line 30.
import lombok.experimental.UtilityClass;
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/util/TemporalActivityUtils.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityConfigurationStrategy.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityConfigurationStrategy.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityConfigurationStrategy.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityConfigurationStrategy.java
Outdated
Show resolved
Hide resolved
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityType.java
Show resolved
Hide resolved
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/util/TemporalActivityUtils.java
Outdated
Show resolved
Hide resolved
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/util/TemporalActivityUtils.java
Outdated
Show resolved
Hide resolved
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/util/TemporalActivityUtils.java
Outdated
Show resolved
Hide resolved
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/util/TemporalActivityUtils.java
Outdated
Show resolved
Hide resolved
...lin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java
Outdated
Show resolved
Hide resolved
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityType.java
Outdated
Show resolved
Hide resolved
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityType.java
Outdated
Show resolved
Hide resolved
gobblin-temporal/src/test/java/org/apache/gobblin/temporal/ddm/activity/ActivityTypeTest.java
Outdated
Show resolved
Hide resolved
...lin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java
Show resolved
Hide resolved
Please update the description explaining the change and what it helps with |
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Created ActivityType Enum
Modified code to create Activity using config based StartToCloseTimeout
Added Activity Heartbeat which will help if Temporal Worker Running Activity dies
Refactored the interfaces to pass properties
Tests
ActivityTypeTest
Commits