Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36838][state/forst] Fix the deadlock when quit forst state backend #26053

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Zakelly
Copy link
Contributor

@Zakelly Zakelly commented Jan 22, 2025

What is the purpose of the change

In #25732 we join the async background threads of ForSt to avoid deadlock when JVM quit. That is an incomplete solution which is also problematic. The background threads are shared among multiple ForSt instances, meaning that simply join those threads may cause background job unfinished in other instances.

The ForSt project has investigated the root cause and gave a solution (ververica/ForSt#30). Thus we should bump the depended ForSt version and revert the thread joining in Flink.

Brief change log

  • Bump ForSt version to 0.1.6
  • Revert the change of background thread joining

Verifying this change

This change is already covered by IT case ForStStateBackendV2Test. If it can normally exit then the problem solved.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@Zakelly Zakelly changed the title [FLINK-36868][state/forst] Fix the deadlock when quit forst state backend [FLINK-36838][state/forst] Fix the deadlock when quit forst state backend Jan 22, 2025
Copy link
Contributor

@fredia fredia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM. Let's wait for the CI...

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 22, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Zakelly Zakelly merged commit 7b2e9c4 into apache:master Jan 23, 2025
@Zakelly Zakelly deleted the f36838-2 branch January 23, 2025 02:22
ryanvanhuuksloot pushed a commit to ryanvanhuuksloot/flink that referenced this pull request Feb 19, 2025
Au-Miner pushed a commit to Au-Miner/flink that referenced this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants