Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support auto computing dark mode #20702

Draft
wants to merge 2 commits into
base: v6
Choose a base branch
from
Draft

feat: support auto computing dark mode #20702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b914c3e
feat(dark): support dark mode
Ovilia Aug 21, 2024
589e155
Merge branch 'v6' into feat/dark-mode
Ovilia Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/core/echarts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ import {
ScaleDataValue,
ZRElementEventName,
ECElementEvent,
AnimationOption
AnimationOption,
Dictionary
} from '../util/types';
import Displayable from 'zrender/src/graphic/Displayable';
import { seriesSymbolTask, dataSymbolTask } from '../visual/symbol';
Expand Down Expand Up @@ -324,6 +325,8 @@ export type EChartsInitOpts = {
locale?: string | LocaleOption,
renderer?: RendererType,
devicePixelRatio?: number,
darkMode?: 'auto' | 'light' | 'dark',
darkColorMap?: Dictionary<string>,
useDirtyRect?: boolean,
useCoarsePointer?: boolean,
pointerSize?: number,
Expand Down Expand Up @@ -412,6 +415,7 @@ class ECharts extends Eventful<ECEventDefinition> {
this._dom = dom;

let defaultRenderer = 'canvas';
let defaultDarkMode = 'auto' as const;
let defaultCoarsePointer: 'auto' | boolean = 'auto';
let defaultUseDirtyRect = false;

Expand Down Expand Up @@ -450,6 +454,8 @@ class ECharts extends Eventful<ECEventDefinition> {
width: opts.width,
height: opts.height,
ssr: opts.ssr,
darkMode: opts.darkMode || defaultDarkMode,
darkColorMap: opts.darkColorMap,
useDirtyRect: retrieve2(opts.useDirtyRect, defaultUseDirtyRect),
useCoarsePointer: retrieve2(opts.useCoarsePointer, defaultCoarsePointer),
pointerSize: opts.pointerSize
Expand Down
2 changes: 1 addition & 1 deletion src/model/globalDefault.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const decalColor = 'rgba(0, 0, 0, 0.2)';
export default {

darkMode: 'auto',
// backgroundColor: 'rgba(0,0,0,0)',
backgroundColor: 'rgba(255,255,255,1)',

colorBy: 'series',

Expand Down
Loading