-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): fix tooltips text style of the theme macarons #17551
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a renference to explain the changes because I cannot find this in v4.
The details of the bug please see the #17542 You can view the different of tooltip show between the two version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. I think this makes sense. It's probably because the default value in ECharts tooptip changed in v5. So it's reasonable to add default values for macarons theme.
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
fix tooltips text style of the theme macarons same as v4.9.0
Fixed issues
Details
Before: What was the problem?
The theme macarons' tooltips style is not sam as it show in v4.9.0
After: How does it behave after the fixing?
The theme macarons' tooltips style is same as the tooltips show in v4.9.0
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information