Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): fix tooltips text style of the theme macarons #17551

Merged
merged 1 commit into from
Aug 26, 2022
Merged

fix(theme): fix tooltips text style of the theme macarons #17551

merged 1 commit into from
Aug 26, 2022

Conversation

mousne
Copy link
Contributor

@mousne mousne commented Aug 23, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix tooltips text style of the theme macarons same as v4.9.0

Fixed issues

Details

Before: What was the problem?

The theme macarons' tooltips style is not sam as it show in v4.9.0

After: How does it behave after the fixing?

The theme macarons' tooltips style is same as the tooltips show in v4.9.0

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 23, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a renference to explain the changes because I cannot find this in v4.

@mousne
Copy link
Contributor Author

mousne commented Aug 25, 2022

Can you provide a renference to explain the changes because I cannot find this in v4.

The details of the bug please see the #17542

And a example is below,
v5
v4

You can view the different of tooltip show between the two version,
then you can check the log which I console the option.tooltip.borderWidth as a example,
there are some other option data is not same,
so it's maybe not the theme's problem,
somewhere have changed the default option value,
but when I check the doc, there is same with the v4 version,
so I think there are some code change make this problem,
other theme also be affected,
but I do not have enough time to check it, and I'm not familiar with the code.
so this pr is only a fast solution with macarons theme,
If you think it's not solve the problem completely, you can close this pr and check the code to fix the bug.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I think this makes sense. It's probably because the default value in ECharts tooptip changed in v5. So it's reasonable to add default values for macarons theme.

@Ovilia Ovilia merged commit 71e9548 into apache:master Aug 26, 2022
@echarts-bot
Copy link

echarts-bot bot commented Aug 26, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.4.0 milestone Sep 5, 2022
100pah added a commit that referenced this pull request Sep 5, 2022
@barry1102
Copy link

v5.4.0
image
v5.3.3
image
升级5.4.0直接导致我的tooltip不好使,让我不得不回退到5.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants