Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] [FEATURE] Add select by brushing in dataZoom #13025

Merged
merged 11 commits into from
Jul 27, 2020
Merged

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Jul 26, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This pull request brings select by brushing interaction in dataZoom. This new interaction also includes changes in UI.

Details

Currently this feature is enabled by default. It can be turned off by setting brushSelect: false.

If it's enabled, it will show an extra handle to indicate the drag zone. Here is a picture to explain the areas for different interactions.

dataZoom-explain

And an interaction GIF:

sliderZoomBrush

New API

dataZoom: {

    brushSelect?: boolean
    brushStyle?: ItemStyleOption

    /**
     * Icon to indicate it is a draggable panel.
     */
    moveHandleIcon?: string
    moveHandleStyle?: ItemStyleOption
    /**
     * Height of handle rect. Can be a percent string relative to the slider height.
     */
    moveHandleSize?: number
    
    emphasis: {
        moveHandleStyle?: ItemStyleOption
    }
}

@echarts-bot
Copy link

echarts-bot bot commented Jul 26, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang merged commit e416d23 into next Jul 27, 2020
@echarts-bot
Copy link

echarts-bot bot commented Jul 27, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the datazoom-brush branch July 27, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants