Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12386] Added series.typeNames values values to english lang. #12387

Conversation

BrianGilbert
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Adds missing series.typeNames values to english translation

Fixed issues

Details

Before: What was the problem?

Translations for series.typeNames were missing.

After: How is it fixed in this PR?

Translations added

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 6, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@susiwen8
Copy link
Contributor

susiwen8 commented Apr 6, 2020

@BrianGilbert Thanks, but you don't have to add dist/ files to this commit.

@BrianGilbert BrianGilbert force-pushed the feature/12386-chart-types-english-translation branch from dcb406c to 9088d73 Compare April 6, 2020 03:01
@BrianGilbert
Copy link
Contributor Author

@susiwen8 ah, thanks, I've updated the PR without them.

@pissang pissang merged commit 57dd7a3 into apache:master Apr 7, 2020
@echarts-bot
Copy link

echarts-bot bot commented Apr 7, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants