Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Line/area series step on data with nulls produces unexpected results #20021

Closed
alxnddr opened this issue Jun 11, 2024 · 1 comment · Fixed by #20092
Closed

[Bug] Line/area series step on data with nulls produces unexpected results #20021

alxnddr opened this issue Jun 11, 2024 · 1 comment · Fixed by #20092
Assignees
Labels
bug en This issue is in English topic: line

Comments

@alxnddr
Copy link

alxnddr commented Jun 11, 2024

Version

5.5.0

Link to Minimal Reproduction

https://echarts.apache.org/examples/en/editor.html?c=line-simple&code=PYBwLglsB2AEC8sDeAoWsAeBBDEDOAXMmurGAJ4gCmRA5AMYCGYVA5sAE7m0A0J6AE2aMiAbVoBZGL1i0AKgFcqM2gHUqAlXIAWClQDEOEFQGVmphdFoBdEgF8-6cjnxFUpMpRqyAbowA2SrT2jrB4VEZUhLCi_MQegsJi0Ar-_jywAKwADBkAbLmwKWkZAOyFAByFxf7WoR4U1HT-ENDK9aSMHFSMJhT-3kiwoIz0EBRE2QB0AEywDnHoeCwgdFTQmh3o9DBt9GAAcqn-0WAcSnF2JLZ2ANxAA

Steps to Reproduce

  1. Have a line/area cartesian chart where first and last data points are null (example)
  2. Set areaStyle: {}
  3. Set step: end and connectNulls: true props
  4. The chart does not appear correctly

Current Behavior

Area polygon is incorrect, the bottom of it is shifted:

Screenshot 2024-06-11 at 3 48 40 PM

Expected Behavior

The area polygon should be correct

Environment

- OS: macos
- Browser: chrome
- Framework: n/a

Any additional comments?

There is a related problem when connectNulls is false:
Screenshot 2024-06-11 at 3 48 19 PM copy

@alxnddr alxnddr added the bug label Jun 11, 2024
@echarts-bot echarts-bot bot added en This issue is in English pending We are not sure about whether this is a bug/new feature. labels Jun 11, 2024
@Ovilia
Copy link
Contributor

Ovilia commented Jun 27, 2024

The polygon one is a bug. But the one in Any additional comments seems to be correct.

This looks as expected to me. Step can be one of 'start', 'middle', 'end'.

@Ovilia Ovilia added not-a-bug waiting-for: author topic: line bug and removed bug pending We are not sure about whether this is a bug/new feature. not-a-bug waiting-for: author labels Jun 27, 2024
@Ovilia Ovilia self-assigned this Jun 27, 2024
@Ovilia Ovilia added this to the 5.5.2 milestone Jun 27, 2024
Ovilia added a commit that referenced this issue Jun 28, 2024
@Ovilia Ovilia removed this from the 5.5.2 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug en This issue is in English topic: line
Projects
None yet
2 participants