Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The documentation for EChartsInitOpts has a type error about height and width #17667

Closed
linghengqian opened this issue Sep 18, 2022 · 2 comments
Labels
bug difficulty: easy Issues that can be fixed more easily than the average. en This issue is in English typescript

Comments

@linghengqian
Copy link
Member

linghengqian commented Sep 18, 2022

Version

master c9e9a02

Link to Minimal Reproduction

Just a documentation error.

Steps to Reproduce

Current Behavior

width Specify width explicitly, in pixel. If setting to null/undefined/'auto', width of dom (instance container) will be used.
height Specify height explicitly, in pixel. If setting to null/undefined/'auto', height of dom (instance container) will be used.

image

Expected Behavior

  • Updating documentation is expected behavior.

Environment

- OS: Windows 11
- Browser: 105.0.1343.42
- Framework: Vue@2

Any additional comments?

@echarts-bot echarts-bot bot added en This issue is in English pending We are not sure about whether this is a bug/new feature. labels Sep 18, 2022
@Ovilia Ovilia added typescript difficulty: easy Issues that can be fixed more easily than the average. and removed pending We are not sure about whether this is a bug/new feature. labels Sep 19, 2022
@echarts-bot
Copy link

echarts-bot bot commented Sep 19, 2022

This issue is labeled with difficulty: easy.
@linghengqian Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.

Please have a look at How to debug ECharts if you'd like to give a try. 🤓

@Ovilia Ovilia added this to the TBD milestone Sep 19, 2022
@linghengqian
Copy link
Member Author

This issue is labeled with difficulty: easy. @linghengqian Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.

Please have a look at How to debug ECharts if you'd like to give a try. 🤓

  • I'm a bit confused about this tag, does this require modifying the document or let's modify the typescript type in echarts.ts ?

@Ovilia Ovilia closed this as completed in 96f859c Oct 8, 2022
Ovilia added a commit that referenced this issue Oct 8, 2022
fix: EChartsInitOpts type error about height and width. close #17667
@Ovilia Ovilia removed this from the TBD milestone Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug difficulty: easy Issues that can be fixed more easily than the average. en This issue is in English typescript
Projects
None yet
Development

No branches or pull requests

2 participants