Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy export will start multi server / Making all export/refer process serial. #969

Closed
wants to merge 3 commits into from

Conversation

bohrqiu
Copy link
Contributor

@bohrqiu bohrqiu commented Nov 29, 2017

What is the purpose of the change

fix some dubbo bug

Brief changelog

  1. lazy export will start multi server
  2. tuning spring event performance
  3. clean FailbackRegistry resouces

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2017

CLA assistant check
All committers have signed the CLA.

chickenlj added a commit that referenced this pull request Nov 30, 2017
@chickenlj
Copy link
Contributor

chickenlj commented Nov 30, 2017

tuning spring event performance

I've fixed this with commit 89b4771

lazy export will start multi server

We're considering solve this by turning all export/refer process serial.
also see this issue #677

@chickenlj
Copy link
Contributor

clean FailbackRegistry resouces

The thread here is daemon, and this is not a critical operation that have to wait.

@bohrqiu
Copy link
Contributor Author

bohrqiu commented Dec 2, 2017

We're considering solve this by turning all export/refer process serial.

why do this?

when there are hundreds of providers/consumer,the startup performance will be slow.

in our internal version:

wechatimg117

@bohrqiu
Copy link
Contributor Author

bohrqiu commented Dec 2, 2017

in our internal version,i have enhance dubbo includes the following:

  1. hessian data compress for across datacenter invokes.

image

  1. export/refer concurrent

  2. dubbo local cache .

dubbo consumer invoke redis first,when cache missing,invoke remote serivce. it use spring el compute key.

wechatimg118

@chickenlj
Copy link
Contributor

Your project cost more than 147s to finish start? Is there any time costing initialization process in your service bean?
Is the cost mainly on the consumer side, waiting for the registry notification of providers and establish connection? If so, maybe we can make the notification process(time costing) asynchronous.

@chickenlj
Copy link
Contributor

dubbo local cache .

You used dubbo's Cache SPI to achieve this?

@chickenlj chickenlj added type/enhancement type/need-triage Need maintainers to triage labels Jan 18, 2018
@chickenlj chickenlj added this to the some day milestone Jan 18, 2018
@chickenlj chickenlj changed the title fix some dubbo bug Lazy export will start multi server / Making all export/refer process serial. Jan 18, 2018
@bohrqiu
Copy link
Contributor Author

bohrqiu commented Feb 7, 2018

Is the cost mainly on the consumer side, waiting for the registry notification of providers and establish connection? If so, maybe we can make the notification process(time costing) asynchronous.

yes,when consumer side refer service,it will establish connection and access registry center,it be better async refer

@bohrqiu
Copy link
Contributor Author

bohrqiu commented Feb 7, 2018

You used dubbo's Cache SPI to achieve this?

it use filter,spring el+redis .

@ralf0131
Copy link
Contributor

Please resolve the conflicts.

@beiwei30
Copy link
Member

@bohrqiu I checked all your changes, and found the similar changes have been made for ServiceBean and FailbackRegistry, and because there's conflict, I manually submit your change made against DubboProtocol, see #1916.

@beiwei30
Copy link
Member

@bohrqiu for other enhancements you mentioned on this PR, would you mind to submit more PRs?

@bohrqiu
Copy link
Contributor Author

bohrqiu commented Jun 11, 2018

@beiwei30 , I will open new PRs, close this PR ,thanks

@bohrqiu bohrqiu closed this Jun 11, 2018
@beiwei30
Copy link
Member

looking forward to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/need-triage Need maintainers to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants