Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add arch picture in readme and delete unused router field. #1279

Merged
merged 2 commits into from
Jun 27, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1279 (c813165) into 3.0 (968650f) will decrease coverage by 3.33%.
The diff coverage is 54.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1279      +/-   ##
==========================================
- Coverage   59.53%   56.19%   -3.34%     
==========================================
  Files         259      272      +13     
  Lines       12737    12803      +66     
==========================================
- Hits         7583     7195     -388     
- Misses       4199     4701     +502     
+ Partials      955      907      -48     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
common/extension/config_center_factory.go 0.00% <ø> (ø)
... and 286 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0e1f6...c813165. Read the comment docs.

Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved these changes

@AlexStocks AlexStocks merged commit 893bfb5 into apache:3.0 Jun 27, 2021
mark4z pushed a commit to mark4z/dubbo-go that referenced this pull request Jul 5, 2021
AlexStocks added a commit that referenced this pull request Jul 5, 2021
…1300)

* build(deps): bump actions/cache from v2.1.4 to v2.1.5

Bumps [actions/cache](https://github.com/actions/cache) from v2.1.4 to v2.1.5.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.4...1a9e213)

Signed-off-by: dependabot[bot] <[email protected]>

* improve etcd version and change create to put (#1203)

* make the package v3router/judger test coverage rate reach 80% (#1260)

* make the package v3router/judger test coverage rate reach 80%

* add router_chain unit test

* refactor imports and some code

* remove blank lines

Co-authored-by: dongjianhui <[email protected]>

* Fix: Graceful shutdown bugs(supplement #1254) (#1257)

* supplementary fix #1254

remove unused comments

fix import cycle

append apache license header

fix gracefulShutdownFilter unittest bug

go fmt

fix gracefulShutdownConfig unittest bug

fix gracefulShutdownConfig unittest bug

go fmt

* improve formatting based on code style

* go fmt

* set RequestsFinished explicitly

* use mutex to protect variables of ShutdownConfig

* ftr: add config (#1258)

* recover gracefulShutdownFilter logic

* remove unused mutex

Co-authored-by: Laurence <[email protected]>

* refine grpc test code (#1266)

* refine grpc test code

* fix test

* remove useless code

* config test grpc server

* registry 默认值问题 (#1275)

Co-authored-by: wangxiaowei14227 <[email protected]>

* config center for more parameters (#1277)

* nacos config center optimize

* up remote config

* add protocol chick

* up:代码优化

* go fmt

* fix: add arch picture in readme and delete unused router field. (#1279)

* fix

* fix: delete notify

* performance optimization: change time.After => time.NewTimer

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xin.Zh <[email protected]>
Co-authored-by: AlexStocks <[email protected]>
Co-authored-by: randy <[email protected]>
Co-authored-by: LaurenceLiZhixin <[email protected]>
Co-authored-by: Mulavar <[email protected]>
Co-authored-by: dongjianhui <[email protected]>
Co-authored-by: XavierNiu <[email protected]>
Co-authored-by: Laurence <[email protected]>
Co-authored-by: gaoxinge <[email protected]>
Co-authored-by: wangxw666 <[email protected]>
Co-authored-by: wangxiaowei14227 <[email protected]>
Co-authored-by: 赵云兴 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants