Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftr: add grpc server reflection register logic #1216

Merged
merged 1 commit into from
May 26, 2021
Merged

ftr: add grpc server reflection register logic #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions protocol/grpc/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"github.com/grpc-ecosystem/grpc-opentracing/go/otgrpc"
"github.com/opentracing/opentracing-go"
"google.golang.org/grpc"
"google.golang.org/grpc/reflection"
)

import (
Expand Down Expand Up @@ -92,6 +93,7 @@ func (s *Server) Start(url *common.URL) {
// wait all exporter ready , then set proxy impl and grpc registerService
waitGrpcExporter(providerServices)
registerService(providerServices, server)
reflection.Register(server)

if err = server.Serve(lis); err != nil {
logger.Errorf("server serve failed with err: %v", err)
Expand Down
2 changes: 1 addition & 1 deletion test/integrate/dubbo/go-client/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.13

require (
dubbo.apache.org/dubbo-go/v3 v3.0.0
github.com/apache/dubbo-go-hessian2 v1.9.1
github.com/apache/dubbo-go-hessian2 v1.9.2
)

replace dubbo.apache.org/dubbo-go/v3 => ../../../../../dubbo-go
42 changes: 42 additions & 0 deletions test/integrate/dubbo/go-client/go.sum
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/integrate/dubbo/go-server/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
//```
// RUN test ${PR_ORIGIN_REPO} && go mod edit -replace=dubbo.apache.org/dubbo-go/v3=github.com/${PR_ORIGIN_REPO}@${PR_ORIGIN_COMMITID} || go get -u dubbo.apache.org/dubbo-go/v3@develop
//```
github.com/apache/dubbo-go-hessian2 v1.9.1
github.com/apache/dubbo-go-hessian2 v1.9.2
)

replace dubbo.apache.org/dubbo-go/v3 => ../../../../../dubbo-go
42 changes: 42 additions & 0 deletions test/integrate/dubbo/go-server/go.sum
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tools/cli/example/server/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.13

require (
dubbo.apache.org/dubbo-go/v3 v3.0.0-00010101000000-000000000000
github.com/apache/dubbo-go-hessian2 v1.9.1
github.com/apache/dubbo-go-hessian2 v1.9.2
)

replace dubbo.apache.org/dubbo-go/v3 => ../../../../../dubbo-go
42 changes: 42 additions & 0 deletions tools/cli/example/server/go.sum
View file
Open in desktop

Large diffs are not rendered by default.