-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:use wasm filter build tags add wasm #567
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #567 +/- ##
===========================================
+ Coverage 54.78% 54.81% +0.02%
===========================================
Files 669 669
Lines 78297 78297
===========================================
+ Hits 42898 42915 +17
+ Misses 31734 31730 -4
+ Partials 3665 3652 -13 see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
关于 wasm,请在 readme 里面也说下吧。给用户说明白,要启用 wasm,需要怎么怎么做 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* limitations under the License. | ||
*/ | ||
|
||
package pluginregistry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pluginregistry 改名为 plugin_registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个改不了,要改的话,ci也要同步改,改动比较大
Kudos, SonarCloud Quality Gate passed!
|
What this PR does:
Which issue(s) this PR fixes:
Fixes #566
Special notes for your reviewer:
Does this PR introduce a user-facing change?: