Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASoC 2022] Pixiu Metrics Implementation #433 #480

Merged
merged 15 commits into from
Sep 19, 2022
Merged

[ASoC 2022] Pixiu Metrics Implementation #433 #480

merged 15 commits into from
Sep 19, 2022

Conversation

gongna-au
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #433

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022 •
edited
Loading

Codecov Report

Merging #480 (36bed53) into develop (119744b) will increase coverage by 0.00%.
The diff coverage is 60.52%.

@@           Coverage Diff            @@
##           develop     #480   +/-   ##
========================================
  Coverage    54.93%   54.93%           
========================================
  Files          662      663    +1     
  Lines        77433    77471   +38     
========================================
+ Hits         42538    42562   +24     
- Misses       31273    31281    +8     
- Partials      3622     3628    +6
Impacted Files Coverage Δ
...ixiu/pkg/common/extension/filter/filter_manager.go 62.22% <0.00%> (-2.90%) ⬇️
pixiu/pkg/filter/prometheus/metric.go 63.88% <63.88%> (ø)
pkg/envoy/admin.go 50.00% <0.00%> (-9.68%) ⬇️
pilot/pkg/config/memory/monitor.go 71.79% <0.00%> (-7.70%) ⬇️
pkg/envoy/instance.go 76.27% <0.00%> (-1.70%) ⬇️
pilot/pkg/networking/core/v1alpha3/httproute.go 88.12% <0.00%> (-0.53%) ⬇️
pkg/istio-agent/xds_proxy_delta.go 52.84% <0.00%> (-0.52%) ⬇️
pilot/pkg/bootstrap/server.go 53.41% <0.00%> (+0.15%) ⬆️
pkg/istio-agent/agent.go 57.21% <0.00%> (+0.48%) ⬆️
pkg/istio-agent/xds_proxy.go 62.90% <0.00%> (+0.86%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

baerwang
baerwang reviewed Sep 14, 2022
View reviewed changes
pixiu/pkg/filter/prometheus/metric.go Outdated Show resolved Hide resolved
pixiu/pkg/filter/prometheus/metric.go Outdated Show resolved Hide resolved
@gongna-au gongna-au requested a review from baerwang September 14, 2022 08:24
baerwang
baerwang reviewed Sep 16, 2022
View reviewed changes
Copy link
Member

@baerwang baerwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix other question

@gongna-au gongna-au requested a review from baerwang September 16, 2022 13:22
@PhilYue PhilYue merged commit 6bfd541 into apache:develop Sep 19, 2022
@PhilYue PhilYue added this to the 0.6.0 milestone Sep 20, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@gongna-au
[ASoC 2022] Pixiu Metrics Implementation apache#433 (apache#480)
d1ecd10 
* add :new change

* add :license

* change and add pushMethod

* change and add pushMethod

* fix:bug

* fix:bug

* fix:review dog message

* fix time ticker bug

* fix ci test failed

* add default config

* add prometheus plugin in register

* add prometheus makedown

* add prometheus makedown
@mark4z mark4z mentioned this pull request Apr 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baerwang baerwang baerwang approved these changes

@mark4z mark4z mark4z approved these changes

@Lvnszn Lvnszn Lvnszn approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

[ASoC 2022] Pixiu Metrics Implementation
7 participants
@gongna-au @codecov-commenter @AlexStocks @Lvnszn @mark4z @baerwang @PhilYue