[ASoC 2022] Optimization of Pixiu timeout feature #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix the ut |
|
fix the git conflict |
get |
get |
PhilYue
reviewed
Sep 6, 2022
PhilYue
reviewed
Sep 6, 2022
PhilYue
reviewed
Sep 6, 2022
PhilYue
reviewed
Sep 6, 2022
|
fix ut |
AlexStocks
approved these changes
Sep 16, 2022
Codecov Report
@@ Coverage Diff @@
## develop #475 +/- ##
===========================================
- Coverage 54.97% 54.92% -0.06%
===========================================
Files 662 662
Lines 77433 77440 +7
===========================================
- Hits 42572 42537 -35
- Misses 31246 31279 +33
- Partials 3615 3624 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mark4z
approved these changes
Sep 23, 2022
CSWYF3634076
force-pushed
the
wyf/timeout
branch
from
761e5d4 to
766e9ac
Compare
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
* timeout http & grpc & dubbo v1.0 * timeout triple 和 其他 * feat:timeout optimization * feat:timeout dubbo * feat:timeout dubbo * feat : timeout * feat : fix conflict * feat : fix ut * feat : modify struct tag * feat : modify struct tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
timeout for pixiu
Which issue(s) this PR fixes:
Fixes #431
Special notes for your reviewer:
对于http2http&https 使用直接在client req中添加timeout的方式
对于htp2grpc 和 http2triple 使用在ctx中添加timeout的方式实现超时
对于http2dubbo 使用在dubbo请求添加超时的方式，使用了 timeout_config --> request_timeout: 1ns 实现，我看这个字段还没有被使用
完善中。。。
Does this PR introduce a user-facing change?:
yes ，需要在config下添加超时条件，例如 timeout ：1ns