Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:consistent hashing #436

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Conversation

baerwang
Copy link
Member

@baerwang baerwang commented Jun 1, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #366

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #436 (1dd5e56) into develop (00d0150) will increase coverage by 0.06%.
The diff coverage is 58.33%.

@@             Coverage Diff             @@
##           develop     #436      +/-   ##
===========================================
+ Coverage    37.20%   37.26%   +0.06%     
===========================================
  Files           55       56       +1     
  Lines         3790     3805      +15     
===========================================
+ Hits          1410     1418       +8     
- Misses        2220     2224       +4     
- Partials       160      163       +3     
Impacted Files Coverage Δ
pkg/server/cluster_manager.go 36.84% <50.00%> (-0.58%) ⬇️
pkg/cluster/loadbalancer/hash/consistent_hash.go 70.00% <70.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@AlexStocks
Copy link
Contributor

dubbogo 里面有个一致性hash实现,看看能否把代码抽取到gost里面,不要写重复代码

@AlexStocks
Copy link
Contributor

dubbogo 里面有个一致性hash实现,看看能否把代码抽取到gost里面,不要写重复代码

https://github.com/apache/dubbo-go/pull/1828/files

@baerwang baerwang requested a review from AlexStocks June 4, 2022 05:53
@baerwang baerwang requested a review from PhilYue June 5, 2022 12:21
pkg/model/cluster.go Outdated Show resolved Hide resolved
pkg/model/cluster.go Outdated Show resolved Hide resolved
@baerwang baerwang requested a review from AlexStocks June 16, 2022 08:59
@ztelur ztelur changed the title feat:consistent hashing wip:feat:consistent hashing Jun 24, 2022
@PhilYue
Copy link
Member

PhilYue commented Jul 1, 2022

Wait for the next version!

@baerwang baerwang force-pushed the feat-consistenthashing branch from 43774df to 84763c7 Compare July 20, 2022 02:12
@PhilYue PhilYue added this to the 0.6.0 milestone Jul 22, 2022
@baerwang baerwang force-pushed the feat-consistenthashing branch from 945e5ae to 1dd5e56 Compare July 25, 2022 05:59
@baerwang baerwang changed the title wip:feat:consistent hashing feat:consistent hashing Jul 25, 2022
@AlexStocks AlexStocks merged commit 7d49001 into apache:develop Jul 26, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@baerwang baerwang deleted the feat-consistenthashing branch January 20, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build a load balance abstraction for invoking request to upstream servers
6 participants