Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] direct dubbo invoke #434

Merged
merged 5 commits into from
Jun 5, 2022

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented May 29, 2022

What this PR does:

  • handle http request to dubbo provider with direct generic call using route and cluster
  • add direct samples

pixiu config.yml

      filter_chains:
          filters:
            - name: dgp.filter.httpconnectionmanager
              config:
                route_config:
                  routes:
                    - match:
                        prefix: "/UserService"
                      route:
                        cluster: "user"
                http_filters:
                  - name: dgp.filter.http.directdubboproxy
                    config:
  clusters:
    - name: "user"
      lb_policy: "lb"
      endpoints:
        - id: 1
          socket_address:
            address: 127.0.0.1
            port: 20000

http post request

	url := "http://localhost:8883/UserService/com.dubbogo.pixiu.UserService/GetUserByName"
	data := "{\"types\":\"string\",\"values\":\"tc\"}"

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2022

Codecov Report

Merging #434 (7206f8a) into develop (a274007) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           develop     #434      +/-   ##
===========================================
- Coverage    37.67%   37.65%   -0.03%     
===========================================
  Files           55       55              
  Lines         3740     3745       +5     
===========================================
+ Hits          1409     1410       +1     
- Misses        2174     2177       +3     
- Partials       157      158       +1     
Impacted Files Coverage Δ
pkg/client/dubbo/dubbo.go 18.83% <ø> (ø)
pkg/server/adapter_manager.go 63.33% <0.00%> (-7.04%) ⬇️
pkg/filter/metric/metric.go 34.21% <100.00%> (ø)
pkg/server/cluster_manager.go 38.46% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f13d7...7206f8a. Read the comment docs.

pkg/filter/http/dubboproxy/dubbo.go Outdated Show resolved Hide resolved
pkg/tracing/driver.go Outdated Show resolved Hide resolved
pkg/filter/http/dubboproxy/dubbo.go Outdated Show resolved Hide resolved
pkg/filter/http/dubboproxy/dubbo.go Show resolved Hide resolved
@ztelur ztelur merged commit 0a54226 into apache:develop Jun 5, 2022
baerwang pushed a commit to baerwang/dubbo-go-pixiu that referenced this pull request Jun 19, 2022
* http to dubbo with direct generic call

* http to dubbo with direct generic call

* fix comment

* fix comment

* fix comment
@PhilYue PhilYue added this to the v0.5.1 milestone Jul 9, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
* http to dubbo with direct generic call

* http to dubbo with direct generic call

* fix comment

* fix comment

* fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants