Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:load balancer strategy mode and add consistent hash #373

Merged
merged 8 commits into from
Mar 25, 2022

Conversation

baerwang
Copy link
Member

@baerwang baerwang commented Mar 1, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Features

refer to #366

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #373 (75697fe) into develop (e68ff8d) will decrease coverage by 0.22%.
The diff coverage is 58.82%.

@@             Coverage Diff             @@
##           develop     #373      +/-   ##
===========================================
- Coverage    39.61%   39.39%   -0.23%     
===========================================
  Files           54       54              
  Lines         3463     3460       -3     
===========================================
- Hits          1372     1363       -9     
- Misses        1929     1934       +5     
- Partials       162      163       +1     
Impacted Files Coverage Δ
pkg/server/cluster_manager.go 37.06% <36.36%> (-0.32%) ⬇️
pkg/adapter/xds/cds.go 57.02% <100.00%> (-0.36%) ⬇️
pkg/config/config_load.go 64.63% <100.00%> (-4.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68ff8d...75697fe. Read the comment docs.

@mark4z mark4z force-pushed the dev-loadbalancer branch from 711387b to 046d3a3 Compare March 1, 2022 13:14
* limitations under the License.
*/

package consistenthashing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baerwang
Copy link
Member Author

baerwang commented Mar 3, 2022

use Rendezvous Hashing algorithm?

https://en.wikipedia.org/wiki/Rendezvous_hashing

@cityiron
Copy link
Contributor

cityiron commented Mar 3, 2022

use Rendezvous Hashing algorithm?

https://en.wikipedia.org/wiki/Rendezvous_hashing

I think you can write it.

curl http://127.0.0.1:8848/nacos/v1/console/health/liveness
sleep 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make curl call to trigger nacos lazy initialization and sleep for waiting completely initialization. it's better to keep it unchaned.

@ztelur ztelur merged commit a27282e into apache:develop Mar 25, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
* feat:load balancer strategy mode and add consistent hash

* fix triple samples ci

* fix:go fmt

* style:use gost library consistent hash

* style:temporary delete consistent hash wait etcd new version upgrade add it back

Co-authored-by: mark4z <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants