Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish trace #257

Merged
merged 4 commits into from
Sep 29, 2021
Merged

polish trace #257

merged 4 commits into from
Sep 29, 2021

Conversation

tydhot
Copy link
Member

@tydhot tydhot commented Sep 25, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #257 (ca37b8b) into develop (32e944a) will increase coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
+ Coverage    39.51%   39.75%   +0.24%     
===========================================
  Files           50       50              
  Lines         2584     2568      -16     
===========================================
  Hits          1021     1021              
+ Misses        1452     1436      -16     
  Partials       111      111              
Impacted Files Coverage Δ
pkg/client/http/http.go 42.16% <0.00%> (-1.05%) ⬇️
pkg/context/http/util.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e944a...ca37b8b. Read the comment docs.

@ztelur
Copy link
Contributor

ztelur commented Sep 26, 2021

because some legacy issue of code, should the change of pkg/client/http/http.go also apply to filter/http/httpproxy/routerfilter.go too ?

@tydhot
Copy link
Member Author

tydhot commented Sep 26, 2021

because some legacy issue of code, should the change of pkg/client/http/http.go also apply to filter/http/httpproxy/routerfilter.go too ?

In this PR, I just optimize the trace code in the existing project. Idk why filter/http/httpproxy/routerfilter.go didn't have any trace code. Maybe should it add in this file?

@@ -24,14 +24,12 @@ import (
"sync"
"time"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拆分import 块 分为 语言的, 本项目的, 外部引用的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a tool to fix it,see "tools" in dubbo-go profile

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

@AlexStocks AlexStocks merged commit 6a282f0 into apache:develop Sep 29, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
polish trace

Former-commit-id: 6a282f0
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
polish trace

Former-commit-id: ae00c5f [formerly 6a282f0]
Former-commit-id: 1bc5784
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants