-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polish trace #257
polish trace #257
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #257 +/- ##
===========================================
+ Coverage 39.51% 39.75% +0.24%
===========================================
Files 50 50
Lines 2584 2568 -16
===========================================
Hits 1021 1021
+ Misses 1452 1436 -16
Partials 111 111
Continue to review full report at Codecov.
|
because some legacy issue of code, should the change of pkg/client/http/http.go also apply to filter/http/httpproxy/routerfilter.go too ? |
In this PR, I just optimize the trace code in the existing project. Idk why filter/http/httpproxy/routerfilter.go didn't have any trace code. Maybe should it add in this file? |
@@ -24,14 +24,12 @@ import ( | |||
"sync" | |||
"time" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
拆分import 块 分为 语言的, 本项目的, 外部引用的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a tool to fix it,see "tools" in dubbo-go profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
polish trace Former-commit-id: 6a282f0
polish trace
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: