Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Pixiu Admin config management finer-grained #171

Merged
merged 35 commits into from
Jun 25, 2021
Merged

make Pixiu Admin config management finer-grained #171

merged 35 commits into from
Jun 25, 2021

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented May 18, 2021

What this PR does:

  • init from api_config fetched from etcd remotely
  • wath api_config change event from etcd
  • use gost etcd and zk dependency

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #171 (a9966e8) into develop (fbaf7ed) will decrease coverage by 5.19%.
The diff coverage is 8.97%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
- Coverage    43.29%   38.09%   -5.20%     
===========================================
  Files           37       36       -1     
  Lines         1834     1848      +14     
===========================================
- Hits           794      704      -90     
- Misses         928     1048     +120     
+ Partials       112       96      -16     
Impacted Files Coverage Δ
pkg/config/api_config.go 3.50% <0.00%> (-7.11%) ⬇️
pkg/pixiu/pixiu_start.go 0.00% <0.00%> (ø)
pkg/router/route.go 76.47% <0.00%> (-13.81%) ⬇️
pkg/service/api/discovery_service.go 43.13% <28.76%> (-21.78%) ⬇️
pkg/registry/zookeeper.go 55.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbaf7ed...a9966e8. Read the comment docs.

pkg/config/api_config.go Outdated Show resolved Hide resolved
pkg/config/api_config.go Outdated Show resolved Hide resolved
pkg/config/api_config.go Show resolved Hide resolved
pkg/config/api_config.go Outdated Show resolved Hide resolved
@xiaoliu10 xiaoliu10 merged commit 29f3232 into apache:develop Jun 25, 2021
@xiaoliu10 xiaoliu10 added this to the v0.3.0 milestone Jul 2, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
* init

* update

* add gin

* baseinfo and resources

* api complete

* import

* import

* update

* update

* update

* update

* replace path with id

* update

* update

* update

* update

* comment

* use go 1.15 run ci to fix ci problem

* use gost zk

* add lock

* modify import and chinese comment

* split func and bugfix

* fix go.mod go.sum

* fix go.mod go.sum

* fix go.mod go.sum

* import location

Former-commit-id: 29f3232
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
* init

* update

* add gin

* baseinfo and resources

* api complete

* import

* import

* update

* update

* update

* update

* replace path with id

* update

* update

* update

* update

* comment

* use go 1.15 run ci to fix ci problem

* use gost zk

* add lock

* modify import and chinese comment

* split func and bugfix

* fix go.mod go.sum

* fix go.mod go.sum

* fix go.mod go.sum

* import location

Former-commit-id: 3479451 [formerly 29f3232]
Former-commit-id: 259fa13
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
* init

* update

* add gin

* baseinfo and resources

* api complete

* import

* import

* update

* update

* update

* update

* replace path with id

* update

* update

* update

* update

* comment

* use go 1.15 run ci to fix ci problem

* use gost zk

* add lock

* modify import and chinese comment

* split func and bugfix

* fix go.mod go.sum

* fix go.mod go.sum

* fix go.mod go.sum

* import location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants