rate limit filter #169
Merged
rate limit filter #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #169 +/- ##
===========================================
+ Coverage 43.14% 43.29% +0.15%
===========================================
Files 33 37 +4
Lines 1757 1834 +77
===========================================
+ Hits 758 794 +36
- Misses 890 928 +38
- Partials 109 112 +3
Continue to review full report at Codecov.
|
…to update_dubbo � Conflicts: � go.mod � go.sum
AlexStocks
approved these changes
Jun 13, 2021
|
pls fix the go.mod confliction. |
# Conflicts: # go.mod # go.sum
williamfeng323
approved these changes
Jun 13, 2021
AlexStocks
approved these changes
Jun 14, 2021
zhangshen023
approved these changes
Jun 23, 2021
| @@ -165,7 +189,7 @@ func getAPIFilterFuncsWithPluginsGroup(plu *config.PluginsInUse) []context.Filte | |||
|
|
|||
| // found with group name | |||
| for _, groupName := range plu.GroupNames { | |||
| pwfMap, found := groupWithPluginsMap[groupName] | |||
| pwfMap, found := groupCache[groupName] | |||
| if found { | |||
There was a problem hiding this comment.
if !found { continue } for _, pwf := range pwfMap { tmpMap[pwf.Name] = pwf.fn }
| @@ -0,0 +1,62 @@ | |||
| /* | |||
There was a problem hiding this comment.
what does this code make sense?
| type Exact struct { | ||
| apiNames map[string]string | ||
|
|
||
| mu sync.RWMutex |
There was a problem hiding this comment.
FYI,I think pointer is better
There was a problem hiding this comment.
mu *sync.RWMutex, this way?
mark4z
added a commit
that referenced
this pull request
Nov 7, 2021
* update dubbo-go to v1.5.6 & fmt sth. * fix fmt * Update go.mod * update dubbo-go to v1.5.6 & fmt sth. * update dubbo-go to v1.5.6 & fmt sth. * fix fmt * rateLimit filter * add licence header * fix imports * add license header * add license header * fix ci * fix matcher var inline * fix ci * fix sync.RWMutex * errors.warp * test table * remove unreachable statement * Pattern pattern,omitempty * update develop * update the docs for ratelimit * update develop * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter Co-authored-by: Zhenxu Ke <[email protected]> Former-commit-id: fbaf7ed
tydhot
pushed a commit
to tydhot/dubbo-go-pixiu
that referenced
this pull request
Nov 10, 2021
* update dubbo-go to v1.5.6 & fmt sth. * fix fmt * Update go.mod * update dubbo-go to v1.5.6 & fmt sth. * update dubbo-go to v1.5.6 & fmt sth. * fix fmt * rateLimit filter * add licence header * fix imports * add license header * add license header * fix ci * fix matcher var inline * fix ci * fix sync.RWMutex * errors.warp * test table * remove unreachable statement * Pattern pattern,omitempty * update develop * update the docs for ratelimit * update develop * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter Co-authored-by: Zhenxu Ke <[email protected]> Former-commit-id: 4cb8c13 [formerly fbaf7ed] Former-commit-id: 83790e7
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
* update dubbo-go to v1.5.6 & fmt sth. * fix fmt * Update go.mod * update dubbo-go to v1.5.6 & fmt sth. * update dubbo-go to v1.5.6 & fmt sth. * fix fmt * rateLimit filter * add licence header * fix imports * add license header * add license header * fix ci * fix matcher var inline * fix ci * fix sync.RWMutex * errors.warp * test table * remove unreachable statement * Pattern pattern,omitempty * update develop * update the docs for ratelimit * update develop * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter * ratelimit filter Co-authored-by: Zhenxu Ke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #10
Special notes for your reviewer:
Does this PR introduce a user-facing change?: