-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix version field #166
fix version field #166
Conversation
cmd/pixiu/pixiu.go
Outdated
@@ -40,7 +40,7 @@ import ( | |||
) | |||
|
|||
// Version pixiu version | |||
var Version = "0.1.0" | |||
var Version = "0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.3.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe v0.2.1 can merge this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiaoliu10 Sorry for my bothering, but I've sent something about ospp program to your email, and there is also an issue I've created about that. Could you please take a look? Thank you so much! 😊
Codecov Report
@@ Coverage Diff @@
## develop #166 +/- ##
========================================
Coverage 40.60% 40.60%
========================================
Files 35 35
Lines 1692 1692
========================================
Hits 687 687
Misses 903 903
Partials 102 102 Continue to review full report at Codecov.
|
I'd rather extract the variable as a build argument, otherwise, this kind of issue is highly possible to occur next time |
So we should put variables like this into config file in the future, right? Should I fix it? |
What I mean is a build argument, not configuration file, take the below as an example |
A release manager should take care of the build argument when drafting a new release, and that doesn't require code changes |
I've understood what you mean, and I will try my best to implement it after learning about Makefile. But before that, I wonder why one of the checks didn't pass and how to fix it. (Maybe this question is ridiculous 😢) |
It's totally ok, there is no such question as ridiculous in community. Don't be panic |
Thanks. |
What this PR does:
Fixed version field.
Which issue(s) this PR fixes:
Fixes #138
Special notes for your reviewer:
Does this PR introduce a user-facing change?: