Fix JoinDataSource to not ignore DataSource layers silently #17726
+515
−406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename createReport() to createModesReport() to reflect the updated functionality. - Update getAnnotation() to getModesAnnotation() to align with the new annotation type. - Add a new test method createQuidemReasonReport() to handle DecoupledTestConfig annotations. - Update getQuidemReasonAnnotations() to handle DecoupledTestConfig annotations. - Update createReport() to handle both NotYetSupported and DecoupledTestConfig annotations. This commit introduces changes to the test methods and annotations to improve clarity and consistency in the test suite.
This reverts commit 173a057.
This reverts commit 293a483.
(cherry picked from commit e875e92)
This reverts commit c236af7.
github-actions
bot
added
Area - Batch Ingestion
Area - Querying
Area - Segment Format and Ser/De
Area - Ingestion
Area - MSQ
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| /** | ||
| * Flatten a datasource into two parts: the left-hand side datasource (the 'base' datasource), and a list of join | ||
| * clauses, if any. | ||
| * @param b |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags
| @@ -485,10 +485,11 @@ | |||
| @Test | |||
| public void testJoinUnderTopLevelSubqueries() | |||
| { | |||
| final JoinDataSource joinDataSource; | |||
Check notice
Code scanning / CodeQL
Unread local variable
processing/src/test/java/org/apache/druid/query/planning/DataSourceAnalysisTest.java
Fixed
Show fixed
Hide fixed
| @@ -107,13 +109,23 @@ | |||
| return getQuerySegmentSpecForLookUp(this).lookup(this, walker); | |||
| } | |||
|
|
|||
| public DataSourceAnalysis getDataSourceAnalysis() | |||
Check notice
Code scanning / CodeQL
Missing Override annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JoinDataSourceusesDataSourceAnalysisas a model - but during construction it ignores some other typedDataSource-screateSegmentMapFunctionon those sourcesDataSourceAnalysisalso acts as a vertex-boundary like object; which makes this a bit more complicated.This change is limited to fix the bug: I think in a followup will be needed to create a separate object which could be used inside the join - and a separate one to work with the boundary - the
DataSource#getAnalysiswas being used at a lot of places so the bugfix was separated for now.