[Feat](json) Support json_search function in 2.0 #40962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -357,6 +373,19 @@ class JsonbPath { | |||
| leg_vector.emplace_back(leg.release()); | |||
There was a problem hiding this comment.
warning: use of undeclared identifier 'leg_vector' [clang-diagnostic-error]
leg_vector.emplace_back(leg.release());
^| @@ -357,6 +373,19 @@ | |||
| leg_vector.emplace_back(leg.release()); | |||
| } | |||
|
|
|||
| void pop_leg_from_leg_vector() { leg_vector.pop_back(); } | |||
There was a problem hiding this comment.
warning: use of undeclared identifier 'leg_vector' [clang-diagnostic-error]
void pop_leg_from_leg_vector() { leg_vector.pop_back(); }
^|
|
||
| bool to_string(std::string* res) const { | ||
| res->push_back(SCOPE); | ||
| for (const auto& leg : leg_vector) { |
There was a problem hiding this comment.
warning: use of undeclared identifier 'leg_vector' [clang-diagnostic-error]
for (const auto& leg : leg_vector) {
^| } | ||
| return true; | ||
| } | ||
|
|
||
| size_t get_leg_vector_size() { return leg_vector.size(); } |
There was a problem hiding this comment.
warning: use of undeclared identifier 'leg_vector' [clang-diagnostic-error]
size_t get_leg_vector_size() { return leg_vector.size(); }
^| } | ||
| return true; | ||
| } | ||
|
|
||
| size_t get_leg_vector_size() { return leg_vector.size(); } | ||
|
|
||
| leg_info* get_leg_from_leg_vector(size_t i) { return leg_vector[i].get(); } |
There was a problem hiding this comment.
warning: use of undeclared identifier 'leg_vector' [clang-diagnostic-error]
leg_info* get_leg_from_leg_vector(size_t i) { return leg_vector[i].get(); }
^| static constexpr auto name = "json_search"; | ||
| static FunctionPtr create() { return std::make_shared<FunctionJsonSearch>(); } | ||
|
|
||
| String get_name() const override { return name; } |
There was a problem hiding this comment.
warning: function 'get_name' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| String get_name() const override { return name; } | |
| [[nodiscard]] String get_name() const override { return name; } |
| static FunctionPtr create() { return std::make_shared<FunctionJsonSearch>(); } | ||
|
|
||
| String get_name() const override { return name; } | ||
| bool is_variadic() const override { return false; } |
There was a problem hiding this comment.
warning: function 'is_variadic' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| bool is_variadic() const override { return false; } | |
| [[nodiscard]] bool is_variadic() const override { return false; } |
|
|
||
| String get_name() const override { return name; } | ||
| bool is_variadic() const override { return false; } | ||
| size_t get_number_of_arguments() const override { return 0; } |
There was a problem hiding this comment.
warning: function 'get_number_of_arguments' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| size_t get_number_of_arguments() const override { return 0; } | |
| [[nodiscard]] size_t get_number_of_arguments() const override { return 0; } |
| bool is_variadic() const override { return false; } | ||
| size_t get_number_of_arguments() const override { return 0; } | ||
|
|
||
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { |
There was a problem hiding this comment.
warning: function 'get_return_type_impl' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { | |
| [[nodiscard]] DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { |
| return make_nullable(std::make_shared<DataTypeJsonb>()); | ||
| } | ||
|
|
||
| bool use_default_implementation_for_nulls() const override { return false; } |
There was a problem hiding this comment.
warning: function 'use_default_implementation_for_nulls' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| bool use_default_implementation_for_nulls() const override { return false; } | |
| [[nodiscard]] bool use_default_implementation_for_nulls() const override { return false; } |
liutang123
force-pushed
the
json_search-2.0
branch
from
d6cdf78 to
4d2187c
Compare
|
|
||
| String get_name() const override { return name; } | ||
| bool is_variadic() const override { return false; } | ||
| size_t get_number_of_arguments() const override { return 3; } |
There was a problem hiding this comment.
warning: function 'get_number_of_arguments' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| size_t get_number_of_arguments() const override { return 3; } | |
| [[nodiscard]] size_t get_number_of_arguments() const override { return 3; } |
|
run buildall |
TPC-H: Total hot run time: 49159 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 211852 ms |
ClickBench: Total hot run time: 30.34 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
liutang123
force-pushed
the
json_search-2.0
branch
from
7d390dc to
6f16877
Compare
liutang123
force-pushed
the
json_search-2.0
branch
from
6f16877 to
7500e4b
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
|
run external |
cambyzju
approved these changes
Sep 20, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick #40948
Issue Number: close #xxx