Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-wip](unique-key-merge-on-write) check whether the partition column is a key column when create table for MOW table #13490

Merged
merged 1 commit into from
Oct 24, 2022
Merged

[feature-wip](unique-key-merge-on-write) check whether the partition column is a key column when create table for MOW table #13490

merged 1 commit into from
Oct 24, 2022

Conversation

liaoxin01
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@liaoxin01
[feature-wip](unique-key-merge-on-write) check whether the partition …
ac30dc9 
…column is a key column when create table for MOW table
@liaoxin01 liaoxin01 changed the title [feature-wip](unique-key-merge-on-write) fix that partition column not key column for MOW table [feature-wip](unique-key-merge-on-write) check whether the partition column is a key column when create table for MOW table Oct 19, 2022
@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Oct 19, 2022
zhannngchen
zhannngchen approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou
Copy link
Contributor

@dataroaring

dataroaring
dataroaring approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 57e248e into apache:master Oct 24, 2022
@liaoxin01 liaoxin01 deleted the fix_pk_partition branch November 14, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
area/planner Issues or PRs related to the query planner reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liaoxin01 @gavinchou @zhannngchen @dataroaring