Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](function)fix be coredump when using json_object function #13443

Merged
merged 3 commits into from
Oct 20, 2022
Merged

[fix](function)fix be coredump when using json_object function #13443

merged 3 commits into from
Oct 20, 2022

Conversation

ChPi
Copy link
Contributor

@ChPi ChPi commented Oct 18, 2022

Proposed changes

Issue Number: close #13442

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@yiguolei
Copy link
Contributor

please add sql based regression test.

@ChPi
Copy link
Contributor Author

ChPi commented Oct 19, 2022

please add sql based regression test.

have added. please take a look.

yiguolei
yiguolei previously approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 19, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. and removed approved Indicates a PR has been approved by one committer. labels Oct 20, 2022
yiguolei
yiguolei approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 1e77403 into apache:master Oct 20, 2022
dataroaring pushed a commit that referenced this pull request Oct 23, 2022
@ChPi @dataroaring
[fix](function)fix be coredump when using json_object function (#13443)
f4948a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization dev/merged-1.1.4 kind/docs Categorizes issue or PR as related to documentation. kind/test reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug](function)fix be coredump when using json_object function
2 participants
@ChPi @yiguolei