Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
bobhan1 committed Feb 24, 2025
1 parent 3f85bc4 commit ea2ad20
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
4 changes: 4 additions & 0 deletions be/src/common/config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1426,6 +1426,10 @@ DEFINE_mInt32(check_tablet_delete_bitmap_interval_seconds, "300");
DEFINE_mInt32(check_tablet_delete_bitmap_score_top_n, "10");
DEFINE_mBool(enable_check_tablet_delete_bitmap_score, "true");

// whether to prune rows with delete sign = 1 in base compaction
// ATTN: this config is only for test
DEFINE_mBool(prune_delete_sign_when_base_compaction, "false");

// clang-format off
#ifdef BE_TEST
// test s3
Expand Down
4 changes: 4 additions & 0 deletions be/src/common/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -1512,6 +1512,10 @@ DECLARE_mInt32(check_tablet_delete_bitmap_interval_seconds);
DECLARE_mInt32(check_tablet_delete_bitmap_score_top_n);
DECLARE_mBool(enable_check_tablet_delete_bitmap_score);

// whether to prune rows with delete sign = 1 in base compaction
// ATTN: this config is only for test
DECLARE_mBool(prune_delete_sign_when_base_compaction);

#ifdef BE_TEST
// test s3
DECLARE_String(test_s3_resource);
Expand Down
3 changes: 2 additions & 1 deletion be/src/olap/tablet_reader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,8 @@ Status TabletReader::_init_delete_condition(const ReaderParams& read_params) {
// Delete sign could not be applied when delete on cumu compaction is enabled, bucause it is meant for delete with predicates.
// If delete design is applied on cumu compaction, it will lose effect when doing base compaction.
// `_delete_sign_available` indicates the condition where we could apply delete signs to data.
_delete_sign_available = (read_params.reader_type == ReaderType::READER_BASE_COMPACTION ||
_delete_sign_available = ((read_params.reader_type == ReaderType::READER_BASE_COMPACTION &&
config::prune_delete_sign_when_base_compaction) ||
read_params.reader_type == ReaderType::READER_COLD_DATA_COMPACTION ||
read_params.reader_type == ReaderType::READER_CHECKSUM);

Expand Down

0 comments on commit ea2ad20

Please sign in to comment.