Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port arrow_typeof to datafusion-function #9524

Merged
merged 10 commits into from
Mar 11, 2024
Merged

Port arrow_typeof to datafusion-function #9524

merged 10 commits into from
Mar 11, 2024

Conversation

yyy1000
Copy link
Contributor

@yyy1000 yyy1000 commented Mar 10, 2024

Which issue does this PR close?

Related #9285.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Mar 10, 2024
@yyy1000 yyy1000 mentioned this pull request Mar 10, 2024
Closed
@yyy1000
Copy link
Contributor Author

yyy1000 commented Mar 10, 2024

The CI fails because https://github.com/apache/arrow-datafusion/pull/9388/files#r1506662726,
I'm wondering whether I should change the test case or wait for #9392 is implemented. 🤔

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Mar 10, 2024
@yyy1000
Copy link
Contributor Author

yyy1000 commented Mar 10, 2024

The CI fails because https://github.com/apache/arrow-datafusion/pull/9388/files#r1506662726, I'm wondering whether I should change the test case or wait for #9392 is implemented. 🤔

Update: I think changing the test case now and revise it later is better. Because now it corresponds to the expected behavior since hint for UDF is not supported. And after hint is supported, we will revise more test cases besides this.

alamb
alamb approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @yyy1000 -- this looks good to me

datafusion/functions/src/core/nullif.rs
@@ -15,8 +15,6 @@
// specific language governing permissions and limitations
// under the License.

//! Encoding expressions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

datafusion/sqllogictest/test_files/functions.slt Outdated
@@ -479,7 +479,7 @@ CREATE TABLE test(
(3, 30);

# Scalar function
statement error Did you mean 'arrow_typeof'?
statement error Invalid function 'arrowtypeof'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is tracked by #9392

@SteveLauC has a PR up for it #9407 which hopefully will land shortly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9407 is ready to go -- I think once we merge that one we can revert this change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3dbafa7

docs/source/user-guide/sql/data_types.md Outdated
@@ -31,7 +31,7 @@ the `arrow_typeof` function. For example:
```sql
select arrow_typeof(interval '1 month');
+-------------------------------------+
| arrowtypeof(IntervalYearMonth("1")) |
| arrow_typeof(IntervalYearMonth("1")) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb
Copy link
Contributor

alamb commented Mar 10, 2024

I took the liberty of merging this PR up from main and resolving conflicts (also I haven't been coding much this week and I wanted some excuse to do so)

@github-actions github-actions bot removed the sqllogictest SQL Logic Tests (.slt) label Mar 10, 2024
@alamb
Copy link
Contributor

alamb commented Mar 10, 2024

The Ci failure seems unrelated https://github.com/apache/arrow-datafusion/actions/runs/8221664632/job/22482282908?pr=9524

I will rerun the windows test

@jayzhan211 jayzhan211 mentioned this pull request Mar 10, 2024
Closed
43 tasks
@jayzhan211
Copy link
Contributor

The Ci failure seems unrelated https://github.com/apache/arrow-datafusion/actions/runs/8221664632/job/22482282908?pr=9524

I will rerun the windows test

I had meet this error several times, but it is not reproducible. It only appears at the first time after compilation, but not always 😕

@alamb
Copy link
Contributor

alamb commented Mar 10, 2024

The Ci failure seems unrelated https://github.com/apache/arrow-datafusion/actions/runs/8221664632/job/22482282908?pr=9524
I will rerun the windows test

I had meet this error several times, but it is not reproducible. It only appears at the first time after compilation, but not always 😕

I think it is likely a intermittent failure related to the test output not being deterministic (like maybe it depends on the order of thread execution or something). It is probably worth a ticket to track it (but I am about out of time today)

@yyy1000
Copy link
Contributor Author

yyy1000 commented Mar 10, 2024

I took the liberty of merging this PR up from main and resolving conflicts (also I haven't been coding much this week and I wanted some excuse to do so)

Thanks! @alamb

@alamb alamb changed the title Port arrowtypeof to datafusion-function Port arrow_typeof to datafusion-function Mar 11, 2024
@yyy1000
Copy link
Contributor Author

yyy1000 commented Mar 11, 2024

I resolved the conflict with main branch :)

@alamb
Copy link
Contributor

alamb commented Mar 11, 2024

I resolved the conflict with main branch :)

We are sooooo close 🙏

@alamb alamb merged commit 6354df6 into apache:main Mar 11, 2024
23 checks passed
@alamb
Copy link
Contributor

alamb commented Mar 11, 2024

Thanks again @yyy1000

@yyy1000 yyy1000 deleted the port-core branch March 11, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yyy1000 @alamb @jayzhan211