Fix right, full join handling when having multiple non-matching rows at the left side #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
commented
Aug 9, 2021
| @@ -745,9 +747,12 @@ fn build_join_indexes( | |||
| &keys_values, | |||
| )? { | |||
| left_indices.append_value(i)?; | |||
| } else { | |||
| left_indices.append_null()?; | |||
| right_indices.append_value(row as u32)?; | |||
There was a problem hiding this comment.
This is the fix, instead of adding the (left=null, right) to every non-match, it does it only once at the end if there wasn't a single match.
Dandandan
changed the title
alamb
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
Talk about a speedy bugfix 🐎 ! I barely filed the ticket and there is a fix ready :)
One thing that might help readability would be to rename from double negative (no_match false) to has_match or something
Nice work @Dandandan
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #843
Rationale for this change
Right and hull join had an error where if they wouldn't match multiple left side values, for each value it didn't match it would add a row. This is triggered by the change to #842 which maps any value to a 0 hash. Normally values and null values have different hashes, so they wouldn't have this problem.
Instead the correct behavior is to add a single row if it doesn't match any.
What changes are included in this PR?
Are there any user-facing changes?