Minor: Migrate datafusion-proto tests into it own binary #7668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ongchi
changed the title
alamb
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Thank you @ongchi -- this is great ❤️
I also verified that the tests are run as part of the CI job:
https://github.com/apache/arrow-datafusion/actions/runs/6325364178/job/17176970394?pr=7668
...
Running tests/proto_integration.rs (target/debug/deps/proto_integration-bc8eb5a99036abde)
running 73 tests
test cases::roundtrip_logical_plan::round_trip_scalar_types ... ok
test cases::roundtrip_logical_plan::round_trip_datatype ... ok
test cases::roundtrip_logical_plan::round_trip_scalar_values ... ok
test cases::roundtrip_logical_plan::roundtrip_approx_percentile_cont ... ok
test cases::roundtrip_logical_plan::roundtrip_aggregate_udf ... ok
test cases::roundtrip_logical_plan::roundtrip_between ... ok
test cases::roundtrip_logical_plan::roundtrip_case ... ok
test cases::roundtrip_logical_plan::roundtrip_case_with_null ... ok
test cases::roundtrip_logical_plan::roundtrip_binary_op ... ok
test cases::roundtrip_logical_plan::roundtrip_count ... ok
test cases::roundtrip_logical_plan::roundtrip_count_distinct ... ok
test cases::roundtrip_logical_plan::roundtrip_cube ... ok
test cases::roundtrip_logical_plan::roundtrip_cast ... ok
test cases::roundtrip_logical_plan::roundtrip_dfschema ... ok
test cases::roundtrip_logical_plan::roundtrip_field ... ok
test cases::roundtrip_logical_plan::roundtrip_grouping_sets ... ok
test cases::roundtrip_logical_plan::roundtrip_ilike ... ok
test cases::roundtrip_logical_plan::roundtrip_inlist ... ok
test cases::roundtrip_logical_plan::roundtrip_is_not_null ... ok
test cases::roundtrip_logical_plan::roundtrip_is_null ... ok
test cases::roundtrip_logical_plan::roundtrip_like ... ok
test cases::roundtrip_logical_plan::roundtrip_custom_tables ... ok
test cases::roundtrip_logical_plan::roundtrip_logical_plan ... ok
test cases::roundtrip_logical_plan::roundtrip_logical_plan_with_extension ... ok
test cases::roundtrip_logical_plan::roundtrip_logical_plan_with_view_scan ... ok
...
|
Thanks again @ongchi |
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
* Migrate logical plan tests * Migrate physical plan tests * Migrate serialize tests * Migrate test data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7600
Rationale for this change
What changes are included in this PR?
As title.
Are these changes tested?
Are there any user-facing changes?
No.