Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Update documentation of case expression #7646

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

ongchi
Copy link
Contributor

@ongchi ongchi commented Sep 25, 2023

Which issue does this PR close?

This PR is a document fix, does not refer to an issue.

Rationale for this change

The example of case expression in the user guide is not quite correct and misleading. The otherwise(expr) in case expression returns a Result<Expr> which cannot chain with end() expression.

What changes are included in this PR?

Update User Guide -> Expression API -> Conditional Expressions user guide has been update.

Are these changes tested?

Documentation change only does not change any code.

Are there any user-facing changes?

No.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for the contribution @ongchi

I built the docs locally and it looks nice to me ❤️

Screenshot 2023-09-25 at 3 47 23 PM

@alamb alamb changed the title Update documentation of case expression Minor: Update documentation of case expression Sep 25, 2023
@alamb alamb merged commit 2d11436 into apache:main Sep 25, 2023
@ongchi ongchi deleted the doc-case-expression-fix branch September 26, 2023 01:03
Ted-Jiang pushed a commit to Ted-Jiang/arrow-datafusion that referenced this pull request Oct 7, 2023
* docs: update case expression

* Format with prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants