Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose contents of Constraints #7603

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Expose contents of Constraints #7603

merged 1 commit into from
Sep 20, 2023

Conversation

tv42
Copy link
Contributor

@tv42 tv42 commented Sep 19, 2023

Which issue does this PR close?

Closes #7511

Rationale for this change

Make the whole LogicalPlan introspectable again.

What changes are included in this PR?

Are these changes tested?

Simple unit test included.

Are there any user-facing changes?

Publishes Constraint.

Implements Deref for Constraints to get &[Constraint]. This allows iterating Constraints (Without having to implement a whole iterator, or using impl Iterator; code is easy to switch to either of those approaches is someone has a very strong opinion. KISS sounds right to me.).

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tv42 -- looks great

@alamb alamb merged commit a2a09c7 into apache:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Constraints internals
2 participants