Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix catalog's usage docs error and add docs about CatalogList trait #7582

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

tanruixiang
Copy link
Member

@tanruixiang tanruixiang commented Sep 18, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

The documentation misuses MemoryCatalogList and missings the introduction of CatalogList. There are also some markdown structure issues.

What changes are included in this PR?

Fix docs's errors and add the CatalogList trait content.

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tanruixiang

cc @tshauck (someone is reading the documentation)

@alamb alamb changed the title chore: fix catalog's usage docs error and add missing trait content chore: fix catalog's usage docs error and add notes about CatalogList trait Sep 18, 2023
@alamb alamb changed the title chore: fix catalog's usage docs error and add notes about CatalogList trait chore: fix catalog's usage docs error and add docs about CatalogList trait Sep 18, 2023
@alamb alamb merged commit 44b3318 into apache:main Sep 18, 2023
@tshauck
Copy link
Contributor

tshauck commented Sep 18, 2023

nice -- thanks from me as well @tanruixiang

@tanruixiang
Copy link
Member Author

Thanks to @alamb and @tshauck. I'm gathering information to introduce developers who will be using datafusion but new to datafusion to how to use datafusion. I'm happy and look forward to continuing to help the community improve the documentation.

@tanruixiang tanruixiang deleted the fix_catalog_usage branch September 18, 2023 15:17
@alamb
Copy link
Contributor

alamb commented Sep 18, 2023

I'm happy and look forward to continuing to help the community improve the documentation.

that would be most appreciated and valuable @tanruixiang -- it is an area that really could use more improvement and will help future users a lot. THANK YOU 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants