Add binary coercion in like #7349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
|
The code looks good -- this PR also needs a test You can use the |
viirya
reviewed
Aug 21, 2023
| @@ -680,6 +680,7 @@ pub fn like_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataTyp | |||
| string_coercion(lhs_type, rhs_type) | |||
| .or_else(|| dictionary_coercion(lhs_type, rhs_type, false)) | |||
| .or_else(|| null_coercion(lhs_type, rhs_type)) | |||
| .or_else(|| binary_coercion(lhs_type, rhs_type)) | |||
There was a problem hiding this comment.
This coerces string to binary, but currently Like expr only works on string array. I saw you did a commit which adds binary support to Like but it was removed.
|
Actually this does not work, I am trying to figure it out. Will post updates soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #7342
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?