refine: substr error
#7339
Merged
refine: substr error
#7339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
jackwener
approved these changes
Aug 19, 2023
jackwener
reviewed
Aug 19, 2023
Co-authored-by: jakevin <[email protected]>
Co-authored-by: jakevin <[email protected]>
alamb
approved these changes
Aug 21, 2023
| DataType::Utf8 => $utf8Type, | ||
| DataType::Null => DataType::Null, | ||
| _ => { | ||
| // this error is internal as `data_types` should have captured this. |
There was a problem hiding this comment.
this comment appears to be out of date. However, the code is good so I think we can merge this PR in as is. Thank you @Weijun-H
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7326
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?