Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(functions): fix function names typo #7269

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

appletreeisyellow
Copy link
Contributor

@appletreeisyellow appletreeisyellow commented Aug 11, 2023

Which issue does this PR close?

This is a followup PR for #7262. No related issue.

Rationale for this change

I found typos in function names that will printout in error message:

  • regex_replace should be regexp_replace
  • rtrimp should be rtrim
DataFusion CLI v23.0.0
❯ SELECT regexp_replace(arrow_cast('foobar', 'Dictionary(Int32, Utf8)'), 'bar', 'xx', 'gi');
Internal error: The "regex_replace" function can only accept strings.. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
                         ^
❯ SELECT rtrim(arrow_cast(' foo ', 'Dictionary(Int32, Utf8)'));
Internal error: The "rtrimp" function can only accept strings.. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
                          ^

What changes are included in this PR?

Fix typos

Are these changes tested?

Tested manually, there is no logic change in this PR

Are there any user-facing changes?

Users will see the correct function names in the error messages for regexp_replace and rtrim

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Aug 11, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find -- thank you @appletreeisyellow !

@alamb alamb merged commit a3e5943 into apache:main Aug 11, 2023
@appletreeisyellow appletreeisyellow deleted the chunchun/fix-typo branch August 13, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants