Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sqllogictests-doc): add testing set up #7258

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

appletreeisyellow
Copy link
Contributor

Which issue does this PR close?

No related issue

Rationale for this change

In order to run the sqllogictests, users need to set up their testing environment. @alamb pointed me this doc for the set up instructions. I found them useful, so adding them here

What changes are included in this PR?

Add testing set up instructions in the sqllogictests README

Are these changes tested?

Doc change, so no test

Are there any user-facing changes?

Yes, the README for sqllogictests will look like this:
Screenshot 2023-08-10 at 8 58 05 AM

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Aug 10, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @appletreeisyellow !

@alamb alamb merged commit fe4f5bf into apache:main Aug 10, 2023
@appletreeisyellow appletreeisyellow deleted the chunchun/add-test-doc branch August 10, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants