Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in substrait #7224

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix: typo in substrait #7224

merged 1 commit into from
Aug 8, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Aug 8, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

Try to encode - in substrait will report an error that "substract" is not supported

 170   │ 2023-08-08T03:52:46.109050Z  WARN servers::mysql::server: Internal error occurred during query exec, server actively close the channel to let client try next time: Failed to collect recordbatch, source: Failed to poll stream, source: External error: External er
       │ ror, source: Failed to request remote peer, source: Failed to do Flight get, code: Internal error, source: This feature is not implemented: Unsupported function name: "substract".

What changes are included in this PR?

Correct typo "substract" to "subtract"

Are these changes tested?

Yes

Are there any user-facing changes?

No

Signed-off-by: Ruihang Xia <[email protected]>
@github-actions github-actions bot added the substrait Changes to the substrait crate label Aug 8, 2023
@jackwener jackwener merged commit 71be0fc into apache:main Aug 8, 2023
@waynexia waynexia deleted the typo-subtract branch August 8, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
substrait Changes to the substrait crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants