Minor: Add constructors to GetFieldAccessExpr and add docs #7219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 7, 2023
| pub fn new(arg: Arc<dyn PhysicalExpr>, field: GetFieldAccessExpr) -> Self { | ||
| Self { arg, field } | ||
| } | ||
|
|
||
| /// Get the input field | ||
| /// Create a new [`GetIndexedFieldExpr`] for accessing the named field | ||
| pub fn new_field(arg: Arc<dyn PhysicalExpr>, name: impl Into<String>) -> Self { |
There was a problem hiding this comment.
I made these new functions and updated the tests to use them to avoid repetition
|
CI is failing due to #7221 |
yjshen
approved these changes
Aug 8, 2023
jackwener
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #7193
Minor follow on to https://github.com/apache/arrow-datafusion/pull/7215/files
Rationale for this change
I figured this code could have some more comments and make it easier to construct tests
What changes are included in this PR?
Minor: Add constructors to GetFieldAccessExpr and add docs
Are these changes tested?
Yes
Are there any user-facing changes?