Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't track files generated by regen.sh #7204

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Aug 4, 2023

Which issue does this PR close?

Closes #7203

Rationale for this change

regen.sh generates the following files.

  • proto_descriptor.bin
  • datafusion.rs
  • datafusion.serde.rs

They are transitionally used but should not be tracked.

What changes are included in this PR?

Added entries to .gitignore.

Are these changes tested?

I confirmed git status ignores them.

Are there any user-facing changes?

No.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified these files are not present in my checkout. Thank you @sarutak

@alamb alamb merged commit 7e8fe10 into apache:main Aug 5, 2023
@alamb alamb added the development-process Related to development process of DataFusion label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't track files generated by regen.sh
2 participants