fix: skip compression tests on --no-default-features #7172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `cargo test -p datafusion --no-default-features --lib` failed with 77 tests panicking with the message: > Compression is not supported in this build This commit fixes this test failure under --no-default-features by excluding the tests via `#[cfg(feature = "compression")]`.
|
Perhaps the CI should run the tests with |
alamb
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Thank you very much @not-my-profile -- this is great and a very nice contribution to DataFusion
Perhaps the CI should run the tests with --no-default-features as well to spot such errors?
Yes that makes a lot of sense. Would you be able to create a PR to do so?
jackwener
approved these changes
Aug 2, 2023
|
Thanks @not-my-profile |
not-my-profile
added a commit
to not-my-profile/arrow-datafusion
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
cargo test -p datafusion --no-default-features --libfailed with 77 tests panicking with the message:This commit fixes this test failure under --no-default-features by excluding the tests via
#[cfg(feature = "compression")].