refactor: with_inputs() can use original schema to avoid recompute schema. #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
jackwener
commented
Jul 24, 2023
| final_join_result, | ||
| Arc::new(join_plan), | ||
| join_schema.clone(), |
There was a problem hiding this comment.
project_schema isn't necessary equal join_schema.
Sometime, project_schema is subset of join_schema, so recompute schema is more right.
jackwener
commented
Jul 24, 2023
Comment on lines
-1242
to
-1245
| let input_schema = DFSchema::new_with_metadata( | ||
| exprlist_to_fields(&projected_expr, &plan)?, | ||
| plan.schema().metadata().clone(), | ||
| )?; |
There was a problem hiding this comment.
It's useless, because Projection::try_new( already contains it,
jackwener
commented
Jul 24, 2023
| @@ -482,7 +482,38 @@ impl LogicalPlan { | |||
| } | |||
|
|
|||
| pub fn with_new_inputs(&self, inputs: &[LogicalPlan]) -> Result<LogicalPlan> { | |||
| from_plan(self, &self.expressions(), inputs) | |||
| // with_new_inputs use original expression, | |||
| // so we don't need to recompute Schema. | |||
There was a problem hiding this comment.
to avoid useless recompution.
alamb
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Don't need
Are there any user-facing changes?