Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the column aliases below the SubqueryAlias #7035

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Move the column aliases below the SubqueryAlias #7035

merged 3 commits into from
Jul 20, 2023

Conversation

jonahgao
Copy link
Member

@jonahgao jonahgao commented Jul 20, 2023

Which issue does this PR close?

Closes #7027.

Rationale for this change

Reposition the projection from the top of the SubqueryAlias to below, so that the columns referenced from the SubqueryAlias can have their qualifiers.

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the sql SQL Planner label Jul 20, 2023
@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jul 20, 2023
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! thank you @jonahgao

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonahgao -- very much appreciated 🙏

@alamb alamb merged commit 27d6815 into apache:main Jul 20, 2023
@jonahgao jonahgao deleted the issue_7027 branch July 21, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sql SQL Planner sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on Join: Schema error: Schema contains duplicate unqualified field name
3 participants