Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Merge Expr::Like and Expr::ILike #7007

Merged
merged 3 commits into from
Jul 19, 2023
Merged

refactor: Merge Expr::Like and Expr::ILike #7007

merged 3 commits into from
Jul 19, 2023

Conversation

waynexia
Copy link
Member

Which issue does this PR close?

Closes #6841.

Rationale for this change

Both Expr::Like and Expr::ILike are based on the same struct Like (actually Expr::Similar is also based on it). We can add one marker case_insensitive in struct Like to distinguish them. This can simplify related logic on handling LIKE and ILIKE.

What changes are included in this PR?

Merge Expr::Like and Expr::ILike variants

Are these changes tested?

By existing tests

Are there any user-facing changes?

Yes, this is a breaking change as Expr doesn't have Expr::ILike now.

@waynexia waynexia added the api change Changes the API exposed to users of the crate label Jul 18, 2023
@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate labels Jul 18, 2023
jackwener
jackwener approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

@waynexia
fix docs
9b3f6d6 
Signed-off-by: Ruihang Xia <[email protected]>
@alamb
Copy link
Contributor

alamb commented Jul 19, 2023

Thank you @waynexia -- I agree with @jackwener that this is a really nice cleanup

@alamb alamb merged commit bb2b39c into apache:main Jul 19, 2023
@waynexia waynexia deleted the merge-like branch July 19, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwener jackwener jackwener approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner substrait Changes to the substrait crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: combine Expr::Like and Expr::ILike
3 participants
@waynexia @alamb @jackwener